Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BigInt compactibility of mobile browsers #5613

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Update BigInt compactibility of mobile browsers #5613

merged 2 commits into from
Sep 22, 2020

Conversation

MuhammedZakir
Copy link
Contributor

@MuhammedZakir MuhammedZakir commented Sep 17, 2020 •
edited
Loading

Edit: This PR updates Opera Mobile BigInt support, n -> y.

Android*: 81 -> 67
Chrome: 85 -> 67
Firefox: 79 -> 68
Opera Mobile*: 46 -> 48
Samsung Internet: 9.2 -> 9.0

Source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#Browser_compatibility

  • Here, I presume "Opera Mobile" is for Android and "Android Browser" is "Android Webview". Correct me if I am wrong! :-)

@MuhammedZakir
Update BigInt compactibility of mobile browsers
c4f2c20 
Android*: 81 -> 67
Chrome: 85 -> 67
Firefox: 79 -> 68
Opera Mobile*: 46 -> 48
Samsung Internet: 9.2 -> 9.0

Source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#Browser_compatibility

* Here, I presume "Opera Mobile" is for Android and "Android Browser" is "Android Webview". Correct me if I am wrong! :-)
@atjn
Copy link
Contributor

atjn commented Sep 17, 2020

Hi there, and welcome to Caniuse :)

Caniuse does not work in the same way as MDN does. When (for example) Firefox 79 is marked y, it does not mean that BigInt was added in Firefox 79, but rather that we are only tracking Firefox 79, and that it happens to support BigInt.
It is not currently possible to change the tracked versions, as stated in the contributing guidelines.

If you, like me, think Caniuse should be tracking older versions of mobile browsers, i suggest creating an issue for it or voting for an existing one, like #3518

Specifically when it comes to Opera Mobile, @Fyrd is currently working on updating the tracked version to v59. I suggest removing the other changes and keeping this PR open with the update to Opera Mobile support, then @Fyrd will merge it as soon as he is ready with a full update to all tables. Thanks!

By the way, your presumption is correct 👍

@MuhammedZakir
Copy link
Contributor Author

MuhammedZakir commented Sep 18, 2020 •
edited
Loading

Hi there, and welcome to Caniuse :)

:-)

Caniuse does not work in the same way as MDN does. When (for example) Firefox 79 is marked y, it does not mean that BigInt was added in Firefox 79, but rather that we are only tracking Firefox 79, and that it happens to support BigInt.

I take first version marked as "yes" for a feature as the first version of that browser to support it. When someone checks compatibility table, I think that's what they would expect too. So wouldn't this just confuse users? Is there a specific reason for this?

It is not currently possible to change the tracked versions, as stated in the contributing guidelines.

I didn't connect that to this.

If you, like me, think Caniuse should be tracking older versions of mobile browsers, i suggest creating an issue for it or voting for an existing one, like #3518

I am confused. Are we tracking whether specific versions support a feature or not? As opposed to how MDN does - tracking the first version to support a feature? Is that how it is?

Specifically when it comes to Opera Mobile, @Fyrd is currently working on updating the tracked version to v59. I suggest removing the other changes and keeping this PR open with the update to Opera Mobile support, then @Fyrd will merge it as soon as he is ready with a full update to all tables. Thanks!

By the way, your presumption is correct 👍

Okay. I will remove them later.

@atjn
Copy link
Contributor

atjn commented Sep 18, 2020

Are we tracking whether specific versions support a feature or not? As opposed to how MDN does - tracking the first version to support a feature? Is that how it is?

Yes, exactly.

I take first version marked as "yes" for a feature as the first version of that browser to support it. When someone checks compatibility table, I think that's what they would expect too. So wouldn't this just confuse users?

I think that's a great point, and i suggest that you add it to the discussion in #3518 or somewhere else in the issues section.

...Is there a specific reason for this?

In order to not scatter this discussion across different PR's and Issues, please go to #3518 and read Fyrd's explanation and ask additional questions there :)

This was referenced Sep 18, 2020
Open
Merged
@atjn
Copy link
Contributor

atjn commented Sep 21, 2020

Caniuse has been updated to track Opera Mobile v59 now.

@MuhammedZakir
Copy link
Contributor Author

MuhammedZakir commented Sep 21, 2020 •
edited
Loading

Specifically when it comes to Opera Mobile, @Fyrd is currently working on updating the tracked version to v59. I suggest removing the other changes and keeping this PR open with the update to Opera Mobile support, then @Fyrd will merge it as soon as he is ready with a full update to all tables. Thanks!

Caniuse has been updated to track Opera Mobile v59 now.

Updated.

@atjn
Copy link
Contributor

atjn commented Sep 21, 2020

Awesome, thanks :)

@Fyrd Fyrd merged commit 72cce3d into Fyrd:master Sep 22, 2020
@Fyrd
Copy link
Owner

Fyrd commented Sep 22, 2020

Thanks! (and thanks @atjn for the explanations!)

@MuhammedZakir MuhammedZakir deleted the patch-1 branch September 22, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MuhammedZakir @atjn @Fyrd